Author Topic: Fix for channel emotes  (Read 3391 times)

Offline Aransus

  • Acquaintance
  • *
  • Posts: 2
    • View Profile
Fix for channel emotes
« on: September 14, 2006, 03:23:23 pm »
Shadyman@QuantumScape raised an issue on the ds channel today. You can replicate the issue by typing 'qtip', followed by 'creemote qtip'. Notice that in a room, everything looks fine. On the channel, however, the first verb appears in all four verb slots ('takes' instead of 'takes'/'stares'/'sticks'/'exclaims').



The root of the problem is in /secure/sefun/messaging.c, on line 346 of stock DS2.1:



words = ""+pluralize(verb[0]);



The line -should- read:



words = ""+pluralize(verb[verb_count++]);



The incorrect line only appears in the section that applies to an emote observer (the code for 'target' and 'subject' is correct). That's why the screwy output only shows up on channels, or in a room if you're a non-targetted observer.



If this has already been fixed, or I've muffed up something else by changing the line, let me know. Thanks!



Note: So far, the only way I've been able to make this change take effect is by rebooting the mud. I've tried updating (even with the -r switch) /daemon/soul, /secure/daemon/chat, /secure/sefun/messaging, and /secure/daemon/master. If someone knows how to make this take effect without a reboot, please post. Thanks!



-- Aransus

Offline shadyman

  • Friend
  • **
  • Posts: 50
    • View Profile
Fix for channel emotes
« Reply #1 on: September 14, 2006, 03:26:52 pm »

Ace!  B-)



Good eyes. I figured it was something I had done until i got on Dead Souls Demo and managed the same bug.  (nod)


Offline cratylus

  • Your favorite and best
  • Administrator
  • ***
  • Posts: 1022
  • Cratylus@Dead Souls <ds> np
    • View Profile
    • About Cratylus
Fix for channel emotes
« Reply #2 on: September 14, 2006, 03:43:14 pm »

Aransus,



Swell! I'll test it tonight. I presume you don't have a problem with

me adding it to the distro.



Offline tigwyk

  • Acquaintance
  • *
  • Posts: 45
    • View Profile
Fix for channel emotes
« Reply #3 on: September 14, 2006, 05:43:40 pm »

It seems to solve the problem, hooray!



Hooray Aransus! Hooray Crat for adding it to the distro!


Offline Aransus

  • Acquaintance
  • *
  • Posts: 2
    • View Profile
Fix for channel emotes
« Reply #4 on: September 14, 2006, 06:38:39 pm »
You presume correctly, no problems here.



-- Aransus