LPMuds.net

Newbies can see in the dark, and can understand all languages.

It's kind of a legacy feature from before I picked up maintainership...
I've thought about getting rid of it because it's confusing, but I
think it has upsides as well.

http://dead-souls.net/ds-admin-faq.html#38

-Crat

Kalixt,
You want to use the efun userp(), which returns 1 for an object if it has ever been interactive, like so:

Code: [Select]

int CanReceive(object ob) {
  if (!userp(ob))
    return 0;
  return room::CanReceive(ob);
}

My version doesn't send a message to the mob, it's a waste of code unless the mob is made to respond to it.

I have several comments.

1) You may not redeclare a variable twice. (I know its true for local variables. Im pretty sure this holds for global varaibles also)
2) Its more concise to declare and initialize in one statement. private int rats=random(x)
3) random(2) will generate either 0 or 1. NOT 2.
4) instead of placing code for preventing the rats to leave in other rooms, why not just prevent them from using the north and east commands? This is easier and it keeps all the code for that room in that room.
5) Race is a string in  stock DS (unless you changed it). a) You may have player races which are something other than human. So this may not be desireable. b) Also, there are several events which can change the player's Race from its original value to something else, "undead" comes to mind. Therefore, I would suggest you use your original idea and go with GetRace()=="rat". Then later if you add a wolf to the room, you can add an or statement and include the wolf to keep him in too.

OMG

I'm just...staggered at this code. The problem is most definitely not you.

This is code from years ago, back before I was leet in any way, and now
looking at it fills me with horror and embarrassment.

But hey, obviously my heart was in the right place.

Rather than try to fix the code you've shared (which is, to reiterate,
broken because of my errors), I've created a new set of ammo and
a new box for it, in code that actually works:

[snip]

Also, this is plain unappetizing:

Code: [Select]

    SetKeyName("357round");

because it means that when the thing is addressed by name by the mud,
it may use "357round" in output to the player, which looks crude and
ungrammatical. Instead, this is better:

Code: [Select]

    SetKeyName(".357 round");

This leads us to a peculiar quirk in the parser. If a thing has a caliber
as a SetAdjective, it winds up not getting recognized as a proper adjective.
You need to drop the decimal point, and then you can use the adjective
either with or without the decimal. Yes, weird, but at least it works,
even if it works weirdly.

So, there you have it. You ran into some old, borken code of mine and
that was the problem. I'd like to say that'll never happen again, but,
well, probably it will. Just let me know and I'll make sure it gets
added to my to-do list, like this ammo now is.

In my defense I can only say that I wrote this under an older MudOS driver,
and maybe it worked then. Really can't say, because I'm not planning
on tracking down that old driver and testing. I'm just going to
fix the errors.

Incidentally, now the ammo box will not only say "This cardboard case is for .45 acp ammunition only.",
It also adds "There is not enough room in there!" because the CanReceive()
returns a 0. I don't like this behavior, and will be playing around with
CanReceive() so that it behaves a little less rigidly.

Man. I need a beer after that.

Quote

also, what happened to the code for the rifles?  M16 and 50 cal?

As I recall, it was even buggier than the code we just dissected, so I
just pulled it, intending to re-add it at some point, and just haven't
got around to it. If you'd like, I can bump it up on the to-do list,
since it's not as major a project to me as it once was.

Really the whole firearms/gunshot wounds system needs a good working
over. I came up with it so long ago that it's just disharmonious to me now.

Quote

Well, I'll be happy to test anything you got, I'm putting together a zombie-themed MUD, so I'll have lots of blunt and sharp weapons, but want to throw a few firearms in the mix. I'm not close to going public, so I'd be great for testing code for you

Quote

I also hate the term "clip" in referring to magazines, so I'm changing all that as well.

I've been out of BDU's long enough now that it doesn't hurt to hear "clip"
for "magazine" or "gun" for small arms.

-Crat